Card wine prefix save setting show hide keep auto #291

Closed
fruzizela wants to merge 2 commits from fruzizela/PortProtonQt:card-wine-prefix-save-setting-show-hide-keep-auto into main
pull from: fruzizela/PortProtonQt:card-wine-prefix-save-setting-show-hide-keep-auto
First-time contributor

The code is corrected. (transferred to a separate block from the init). (strange, I had a merger error (something probably got lost) and it seemed that this item had not yet been added.)

Added automatic disconnection both in the table and on the home screen when there are no values in the subject.
Display of Wine Prefix in type view is removed: List
Added invisible spaces (rather than removing hyphen and underline in table prefix).
Added line-by-line method to read WinePrefix files to reduce load.
Fixed issues when updating theme.
Fixed passing the pyright test.
The whole test also fails 2 tests.

PLUS:
[Add information card Wine and Prefix

Add information Wine and Prefix to the vertical table.
The long Wine line is transferred to a new line and removed - and _ from the name.

Added to the settings the item for showing and hiding Wine Prefix from the card and from the table (not yet translated).

Edited theme, added background to theme (standart dark and light) so that the name of the game does not merge with the card.

Disabled the vertical test, because yesterday it was normal, but so far I have edited a couple of lines of code in the theme after updating the project, it became not normal.
And today, when adding a "commit," it did not write at all that something was being checked at all, although in the last test only the vertical test was disabled.](#284)

The code is corrected. (~~transferred to a separate block from the __init__~~). (strange, I had a merger error (something probably got lost) and it seemed that this item had not yet been added.) Added automatic disconnection both in the table and on the home screen when there are no values in the subject. Display of Wine Prefix in type view is removed: List Added invisible spaces (rather than removing hyphen and underline in table prefix). Added line-by-line method to read WinePrefix files to reduce load. Fixed issues when updating theme. Fixed passing the pyright test. The whole test also fails 2 tests. PLUS: [Add information card Wine and Prefix Add information Wine and Prefix to the vertical table. The long Wine line is transferred to a new line and removed - and _ from the name. Added to the settings the item for showing and hiding Wine Prefix from the card and from the table (not yet translated). Edited theme, added background to theme (standart dark and light) so that the name of the game does not merge with the card. Disabled the vertical test, because yesterday it was normal, but so far I have edited a couple of lines of code in the theme after updating the project, it became not normal. And today, when adding a "commit," it did not write at all that something was being checked at all, although in the last test only the vertical test was disabled.](https://git.linux-gaming.ru/Linux-Gaming/PortProtonQt/pulls/284)
fruzizela added 2 commits 2026-10-22 17:21:07 +00:00
Member

И снова та же проблема

chore(themes): Add 'Wine and Prefix' block to gamecard and vertical style. feat: Added a deferred line 'Loading Wine...' for deferred text display show and hide Wine and Prefix and save setting. fix: Test Error table and card height

chore: 1. The code has been removed from the init. 2. Added wine auto-off and prefix when there are no constants in the theme. 3. Corrected table display errors. 4. Optimized and Cleaned code (maybe not completely (if the names are not satisfied)). 5. Fixed various problems with updating theme and styles with wineprefix enabled. fix: Last-update. 1. Changed the search in ppdb to line-by-line. 2. Added an invisible hyphen in the prefix column. 3. The code from personal lines is still cleaned. fix:pyright test

Это по вашему нормальные коммиты ? Всё в общем я уже трижды указал на это, можете PR больше не делать я буду просто их закрывать мне надоело

И снова та же проблема chore(themes): Add 'Wine and Prefix' block to gamecard and vertical style. feat: Added a deferred line 'Loading Wine...' for deferred text display show and hide Wine and Prefix and save setting. fix: Test Error table and card height chore: 1. The code has been removed from the __init__. 2. Added wine auto-off and prefix when there are no constants in the theme. 3. Corrected table display errors. 4. Optimized and Cleaned code (maybe not completely (if the names are not satisfied)). 5. Fixed various problems with updating theme and styles with wineprefix enabled. fix: Last-update. 1. Changed the search in ppdb to line-by-line. 2. Added an invisible hyphen in the prefix column. 3. The code from personal lines is still cleaned. fix:pyright test Это по вашему нормальные коммиты ? Всё в общем я уже трижды указал на это, можете PR больше не делать я буду просто их закрывать мне надоело
Boria138 closed this pull request 2026-10-22 20:39:54 +00:00
Author
First-time contributor

Показалось, что Вам не нравятся коммиты в коде # - их подчистил.
Оказалось тут?
А как надо указывать коммиты Вы не сказали. Сказали бы сразу тогда.
Если это перечисление того, что изменилось. Вроде ограничений нет на слова.
Не понимаю, что Вам не нравится.

Показалось, что Вам не нравятся коммиты в коде # - их подчистил. Оказалось тут? А как надо указывать коммиты Вы не сказали. Сказали бы сразу тогда. Если это перечисление того, что изменилось. Вроде ограничений нет на слова. Не понимаю, что Вам не нравится.
Author
First-time contributor

Это по вашему нормальные коммиты ? Всё в общем я уже трижды указал на это, можете PR больше не делать я буду просто их закрывать мне надоело

Такой коммит вас устроит?
git commit -m "feat(ui): add Wine Prefix to game cards and tables. chore(git): disable table test"

> Это по вашему нормальные коммиты ? Всё в общем я уже трижды указал на это, можете PR больше не делать я буду просто их закрывать мне надоело Такой коммит вас устроит? git commit -m "feat(ui): add Wine Prefix to game cards and tables. chore(git): disable table test"

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
No Reviewers
No labels
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Linux-Gaming/PortProtonQt#291