chore: switch card selection shortcut to space

Signed-off-by: Boris Yumankulov <boria138@altlinux.org>

CHANGELOG.md

@@ -8,7 +8,7 @@
 ### Added
 
 - Добавлен массовый импорт игр из выбранной папки
-- Добавлен режим множественного выделения карточек через контекстное меню: ЛКМ и кнопка A геймпада переключают выделение, Ctrl+клик позволяет выделять карточки напрямую
+- Добавлен режим множественного выделения карточек через контекстное меню: пробел включает и отменяет режим с очисткой выделения, ЛКМ и кнопка A геймпада переключают выделение карточек
 - Добавлены установка и применение темы перетаскиванием скачанного архива в окно приложени
 - В диалог вылета добавлена кнопка скачивания PPDB с linux-gaming.ru с заменой существующего файла, если PPDB доступен и автоматическая загрузка отключена
 - Добавлено предупреждение о кириллице в путях к игре или PortProton

portprotonqt/context_menu_manager.py

@@ -537,7 +537,7 @@ class ContextMenuManager:
                 lambda checked=False, actions=actions: self._start_card_actions(actions, menus)
             )
         menu.addSeparator()
-        cancel_action = menu.addAction(_("Cancel"))
+        cancel_action = menu.addAction(self._get_safe_icon("cancel"), _("Cancel"))
         cancel_action.triggered.connect(self.clear_card_selection)
         menu.setActiveAction(next(action for action in menu.actions() if action.isEnabled() and not action.isSeparator()))
         menu.popup(game_card.mapToGlobal(pos))
@@ -561,7 +561,7 @@ class ContextMenuManager:
                 self._show_card_selection_menu(menu, game_card, pos)
                 return
             self.clear_card_selection()
-            selection_action = menu.addAction(_("Select multiple"))
+            selection_action = menu.addAction(self._get_safe_icon("edit"), _("Select multiple"))
             selection_action.triggered.connect(lambda: self.start_card_selection(game_card))
             menu.setActiveAction(selection_action)
             menu.addSeparator()

portprotonqt/game_card.py

@@ -16,6 +16,7 @@ from PySide6.QtGui import (
     QEnterEvent,
     QFocusEvent,
     QMouseEvent,
+    QKeyEvent,
     QPaintEvent,
 )
 from PySide6.QtCore import QEvent, Signal, Property, Qt, QUrl, QTimer, QSize
@@ -1289,14 +1290,19 @@ class GameCard(AnimatedCard):
 
     def mousePressEvent(self, event: QMouseEvent) -> None:
         if event.button() == Qt.MouseButton.LeftButton:
-            if event.modifiers() & Qt.KeyboardModifier.ControlModifier:
-                self.batch_selected = not self.batch_selected
-                self.update()
-                event.accept()
-                return
             self.click()
         super().mousePressEvent(event)
 
+    def keyPressEvent(self, event: QKeyEvent) -> None:
+        if event.key() == Qt.Key.Key_Space and self.context_menu_manager:
+            if self.context_menu_manager.card_selection_mode:
+                self.context_menu_manager.clear_card_selection()
+            else:
+                self.context_menu_manager.start_card_selection(self)
+            event.accept()
+            return
+        super().keyPressEvent(event)
+
     def cleanup(self):
         """Clean up animations to prevent memory leaks when the card is destroyed."""
         if hasattr(self, 'coverLabel') and self.coverLabel is not None:

portprotonqt/input_manager/keyboard.py

@@ -4,7 +4,7 @@ from typing import cast
 
 from shiboken6 import isValid
 from PySide6.QtCore import QEvent, QObject, QPoint, Qt
-from PySide6.QtGui import QKeySequence
+from PySide6.QtGui import QKeyEvent, QKeySequence
 from PySide6.QtWidgets import (
     QAbstractScrollArea,
     QApplication,
@@ -130,7 +130,7 @@ class KeyboardInputMixin(InputMixin):
                 return True
 
         if event.type() == QEvent.Type.KeyPress:
-            if self._redirect_gamecard_input_to_search(event):
+            if isinstance(event, QKeyEvent) and self._redirect_gamecard_input_to_search(event):
                 return True
             key = self._qt_event_to_input_key(event)
             if key is not None:
@@ -235,7 +235,9 @@ class KeyboardInputMixin(InputMixin):
         1: 'autoInstallSearchLineEdit',
     }
 
-    def _redirect_gamecard_input_to_search(self, event: QEvent) -> bool:
+    def _redirect_gamecard_input_to_search(self, event: QKeyEvent) -> bool:
+        if event.key() == Qt.Key.Key_Space:
+            return False
         focused = self._focused_widget()
         if not isinstance(focused, GameCard):
             return False

tests/test_library_loading.py

@@ -543,19 +543,28 @@ def test_vertical_library_headers_align_with_values(
                            - value.mapToGlobal(value.rect().center()).x()) <= 1
 
 
-def test_control_click_toggles_card_without_opening_details(
+def test_space_enters_and_toggles_card_selection_without_opening_details(
     library_scene: tuple[GameLibraryManager, list[Callable[[QPixmap], None]]],
 ) -> None:
     manager, _ = library_scene
     game = ("Game", "", "", "", "", "game.exe", "", "", "", "", 0, 0, "portproton")
     card = manager._create_game_card(game)
-    position = card.rect().center().toPointF()
-    for selected in (True, False):
-        event = QMouseEvent(QEvent.Type.MouseButtonPress, position, position,
-                            Qt.MouseButton.LeftButton, Qt.MouseButton.LeftButton,
-                            Qt.KeyboardModifier.ControlModifier)
-        card.mousePressEvent(event)
-        assert card.batch_selected is selected
+    from portprotonqt.context_menu_manager import ContextMenuManager
+    from PySide6.QtGui import QKeyEvent
+
+    selection_manager = object.__new__(ContextMenuManager)
+    selection_manager.game_library_manager = manager
+    selection_manager.card_selection_mode = False
+    manager.game_card_cache[(card.name, card.exec_line)] = card
+    card.context_menu_manager = selection_manager
+    event = QKeyEvent(QEvent.Type.KeyPress, Qt.Key.Key_Space, Qt.KeyboardModifier.NoModifier)
+    card.keyPressEvent(event)
+    assert card.batch_selected
+    assert selection_manager.card_selection_mode
+    event = QKeyEvent(QEvent.Type.KeyPress, Qt.Key.Key_Space, Qt.KeyboardModifier.NoModifier)
+    card.keyPressEvent(event)
+    assert not card.batch_selected
+    assert not selection_manager.card_selection_mode
     cast(Any, manager.main_window).openGameDetailPage.assert_not_called()