Boria138/PortProtonQt
4
5
Fork 5
Code Issues 1 Pull Requests Actions Releases 9 Activity

fix(image_utils): remove corrupted cached images on load failure

Browse Source 
Signed-off-by: Boris Yumankulov <boria138@altlinux.org>
This commit is contained in:
Boris Yumankulov
2026-01-13 14:21:11 +05:00
parent dd65021976
commit 8e6c0aafd1
1 changed files with 22 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
portprotonqt/image_utils.py
View File

@@ -71,9 +71,11 @@ def load_pixmap_async(cover: str, width: int, height: int, callback: Callable[[Q
pixmap = QPixmap(local_path)
# Check if the pixmap loaded successfully
if pixmap.isNull():
logger.warning(f"Failed to load image from {local_path}")
finish_with(pixmap)
return
logger.warning(f"Failed to load image from {local_path}, removing corrupted file")
os.remove(local_path)
else:
finish_with(pixmap)
return
def on_downloaded(result: str | None):
pixmap = QPixmap()
@@ -111,9 +113,11 @@ def load_pixmap_async(cover: str, width: int, height: int, callback: Callable[[Q
pixmap = QPixmap(local_path)
# Check if the pixmap loaded successfully
if pixmap.isNull():
logger.warning(f"Failed to load image from {local_path}")
finish_with(pixmap)
return
logger.warning(f"Failed to load image from {local_path}, removing corrupted file")
os.remove(local_path)
else:
finish_with(pixmap)
return
def on_downloaded(result: str | None):
pixmap = QPixmap()
@@ -148,9 +152,11 @@ def load_pixmap_async(cover: str, width: int, height: int, callback: Callable[[Q
pixmap = QPixmap(local_path)
# Check if the pixmap loaded successfully
if pixmap.isNull():
logger.warning(f"Failed to load image from {local_path}")
finish_with(pixmap)
return
logger.warning(f"Failed to load image from {local_path}, removing corrupted file")
os.remove(local_path)
else:
finish_with(pixmap)
return
def on_downloaded(result: str | None):
pixmap = QPixmap()
@@ -181,8 +187,13 @@ def load_pixmap_async(cover: str, width: int, height: int, callback: Callable[[Q
# Check if the pixmap loaded successfully
if pixmap.isNull():
logger.warning(f"Failed to load image from {cover}")
finish_with(pixmap)
return
# Remove corrupted file only if it's in the cache directory
if cover.startswith(image_folder):
logger.warning(f"Removing corrupted cached file {cover}")
os.remove(cover)
else:
finish_with(pixmap)
return
placeholder_path = theme_manager.get_theme_image("placeholder", current_theme_name)
pixmap = QPixmap()