Boria138/PortProtonQt
4
5
Fork 5
Code Issues 1 Pull Requests Actions Releases 8 Activity

Revert "fix(animations): prevent memory leaks by properly clearing animation references"
All checks were successful
Code check / Check code (push) Successful in 1m6s
Details

Browse Source 
This reverts commit 55dcda738b.
This commit is contained in:
Boris Yumankulov
2025-12-30 11:06:15 +05:00
parent 55dcda738b
commit 4c537248f1
1 changed files with 0 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

56
portprotonqt/animations.py
View File

@@ -100,11 +100,6 @@ class GameCardAnimations:
self.scale_anim.setEasingCurve(QEasingCurve(QEasingCurve.Type[self.theme.GAME_CARD_ANIMATION["scale_easing_curve"]]))
self.scale_anim.setStartValue(self.game_card._scale)
self.scale_anim.setEndValue(self.theme.GAME_CARD_ANIMATION["hover_scale"])
def reset_scale_anim():
self.scale_anim = None
self.scale_anim.finished.connect(reset_scale_anim)
self.scale_anim.start()
def handle_leave_event(self):
@@ -125,11 +120,6 @@ class GameCardAnimations:
self.scale_anim.setEasingCurve(QEasingCurve(QEasingCurve.Type[self.theme.GAME_CARD_ANIMATION["scale_easing_curve_out"]]))
self.scale_anim.setStartValue(self.game_card._scale)
self.scale_anim.setEndValue(self.theme.GAME_CARD_ANIMATION["default_scale"])
def reset_scale_anim():
self.scale_anim = None
self.scale_anim.finished.connect(reset_scale_anim)
self.scale_anim.start()
if self.pulse_anim:
self.pulse_anim.stop()
@@ -184,11 +174,6 @@ class GameCardAnimations:
self.scale_anim.setEasingCurve(QEasingCurve(QEasingCurve.Type[self.theme.GAME_CARD_ANIMATION["scale_easing_curve"]]))
self.scale_anim.setStartValue(self.game_card._scale)
self.scale_anim.setEndValue(self.theme.GAME_CARD_ANIMATION["focus_scale"])
def reset_scale_anim():
self.scale_anim = None
self.scale_anim.finished.connect(reset_scale_anim)
self.scale_anim.start()
def handle_focus_out_event(self):
@@ -209,11 +194,6 @@ class GameCardAnimations:
self.scale_anim.setEasingCurve(QEasingCurve(QEasingCurve.Type[self.theme.GAME_CARD_ANIMATION["scale_easing_curve_out"]]))
self.scale_anim.setStartValue(self.game_card._scale)
self.scale_anim.setEndValue(self.theme.GAME_CARD_ANIMATION["default_scale"])
def reset_scale_anim():
self.scale_anim = None
self.scale_anim.finished.connect(reset_scale_anim)
self.scale_anim.start()
if self.pulse_anim:
self.pulse_anim.stop()
@@ -303,12 +283,6 @@ class DetailPageAnimations:
if detail_page and not detail_page.isHidden():
animation.start(QAbstractAnimation.DeletionPolicy.DeleteWhenStopped)
self.animations[detail_page] = animation
def cleanup_animation_ref():
if detail_page in self.animations:
self.animations.pop(detail_page, None)
animation.finished.connect(cleanup_animation_ref)
animation.finished.connect(restore_effect)
animation.finished.connect(load_image_and_restore_effect)
animation.finished.connect(opacity_effect.deleteLater)
@@ -345,12 +319,6 @@ class DetailPageAnimations:
if detail_page and not detail_page.isHidden():
animation.start(QAbstractAnimation.DeletionPolicy.DeleteWhenStopped)
self.animations[detail_page] = animation
def cleanup_animation_ref():
if detail_page in self.animations:
self.animations.pop(detail_page, None)
animation.finished.connect(cleanup_animation_ref)
animation.finished.connect(cleanup_animation)
animation.finished.connect(load_image_and_restore_effect)
else:
@@ -388,12 +356,6 @@ class DetailPageAnimations:
if detail_page and not detail_page.isHidden():
group_anim.start(QAbstractAnimation.DeletionPolicy.DeleteWhenStopped)
self.animations[detail_page] = group_anim
def cleanup_animation_ref():
if detail_page in self.animations:
self.animations.pop(detail_page, None)
group_anim.finished.connect(cleanup_animation_ref)
group_anim.finished.connect(load_image_and_restore_effect)
group_anim.finished.connect(cleanup_animation)
else:
@@ -457,12 +419,6 @@ class DetailPageAnimations:
if animation and not detail_page.isHidden():
animation.start(QAbstractAnimation.DeletionPolicy.DeleteWhenStopped)
self.animations[detail_page] = animation
def cleanup_animation_ref():
if detail_page in self.animations:
self.animations.pop(detail_page, None)
animation.finished.connect(cleanup_animation_ref)
animation.finished.connect(restore_and_cleanup)
animation.finished.connect(opacity_effect.deleteLater)
else:
@@ -503,12 +459,6 @@ class DetailPageAnimations:
if animation and not detail_page.isHidden():
animation.start(QAbstractAnimation.DeletionPolicy.DeleteWhenStopped)
self.animations[detail_page] = animation
def cleanup_animation_ref():
if detail_page in self.animations:
self.animations.pop(detail_page, None)
animation.finished.connect(cleanup_animation_ref)
animation.finished.connect(slide_cleanup)
else:
logger.warning("Animation or detail page invalid when starting slide exit, cleaning up")
@@ -560,12 +510,6 @@ class DetailPageAnimations:
group_anim.start(QAbstractAnimation.DeletionPolicy.DeleteWhenStopped)
self.animations[detail_page] = group_anim
def cleanup_animation_ref():
if detail_page in self.animations:
self.animations.pop(detail_page, None)
group_anim.finished.connect(cleanup_animation_ref)
group_anim.finished.connect(bounce_cleanup)
except RuntimeError:
# Widget was already deleted, which is expected after deleteLater()